Provide Application Insights converters, telemetry type filter and configuration extension #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-insights-converters
stijnmoreels
requested changes
Mar 10, 2020
src/Arcus.Observability.Telemetry.Serilog.Filters/TelemetryTypeFilter.cs
Show resolved
Hide resolved
...emetry.Serilog.Sinks.ApplicationInsights/Converters/ApplicationInsightsTelemetryConverter.cs
Show resolved
Hide resolved
src/Arcus.Observability.Telemetry.Serilog/Extensions/LogEventPropertyValueExtensions.cs
Outdated
Show resolved
Hide resolved
src/Arcus.Observability.Telemetry.Serilog/Extensions/LogEventPropertyValueExtensions.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
stijnmoreels
approved these changes
Mar 17, 2020
src/Arcus.Observability.Telemetry.Core/Extensions/IReadOnlyDictionaryExtensions.cs
Show resolved
Hide resolved
...rcus.Observability.Telemetry.Serilog.Enrichers/Extensions/LogEventPropertyValueExtensions.cs
Show resolved
Hide resolved
This was referenced Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @stijnmoreels, the idea is to have the basics in and add variety of tests in a follow-up PR.
Relates to #14
Relates to #15
Relates to #16
Relates to #17
Relates to #22