Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dependency id to sql dep tracking #376

Conversation

stijnmoreels
Copy link
Member

Adds dependency ID to SQL dependency tracking.

Closes #286
Relates to #243

@netlify
Copy link

netlify bot commented May 24, 2022

Deploy Preview for arcus-observability canceled.

Name Link
🔨 Latest commit e93bc76
🔍 Latest deploy log https://app.netlify.com/sites/arcus-observability/deploys/628c8a425574880008122b59

@stijnmoreels
Copy link
Member Author

Adding this overload could cause some ambiguous overloads if both the Core and Sql package are installed without argument naming.

@fgheysels fgheysels merged commit 9afa093 into arcus-azure:master May 30, 2022
@stijnmoreels
Copy link
Member Author

Adding this overload could cause some ambiguous overloads if both the Core and Sql package are installed without argument naming.

@fgheysels so you think this is not a problem we should worry about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the LogSqlDependency method signature
2 participants