Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: add Kubernetes enricher #28

Merged
merged 14 commits into from
Feb 25, 2020
Merged

FEAT: add Kubernetes enricher #28

merged 14 commits into from
Feb 25, 2020

Conversation

stijnmoreels
Copy link
Member

Closes #19

tomkerkhove
tomkerkhove approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, don't forget docs as well please.

src/Arcus.Observability.Telemetry.Serilog/KubernetesEnricher.cs Outdated Show resolved Hide resolved
src/Arcus.Observability.Telemetry.Serilog/KubernetesEnricher.cs Outdated Show resolved Hide resolved
src/Arcus.Observability.Tests.Unit/Telemetry/KubernetesEnricherTests.cs Show resolved Hide resolved
tomkerkhove
tomkerkhove suggested changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should've been request changes

@stijnmoreels stijnmoreels merged commit 3ee7f98 into arcus-azure:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees

@tomkerkhove tomkerkhove

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a Kubernetes enricher
2 participants
@stijnmoreels @tomkerkhove