feat: add dependency ID to az key vault dependency tracking #251
Conversation
|
✔️ Deploy Preview for arcus-observability ready! 🔨 Explore the source changes: 2f13d09 🔍 Inspect the deploy log: https://app.netlify.com/sites/arcus-observability/deploys/61d7f4953baf0700081b6d7e 😎 Browse the preview: https://deploy-preview-251--arcus-observability.netlify.app |
...ility.Telemetry.Serilog.Sinks.ApplicationInsights/Converters/DependencyTelemetryConverter.cs
Outdated
Show resolved
Hide resolved
| ### Making it easier to link services | ||
|
|
||
| Service-to-service correlation requires linkage between tracked dependencies (outgoing) and requests (incoming). | ||
| Tracking any kind of dependency with the library has the possibility to provide an dependency ID. This ID will be needed later when the incoming request is tracked (dependency ID = request's parent ID). |
There was a problem hiding this comment.
| Tracking any kind of dependency with the library has the possibility to provide an dependency ID. This ID will be needed later when the incoming request is tracked (dependency ID = request's parent ID). | |
| Tracking any kind of dependency with the library has the possibility to provide a dependency ID. This dependency ID will be needed later when the incoming request is tracked (dependency ID = request's parent ID). |
There was a problem hiding this comment.
I'm not sure how to interpret the last sentence ? The (dependency) ID is needed later when the incoming request is tracked. You mean that the dependencyId is used in the logging of the downstream dependency to correlate the request id with the dependency id ?
There was a problem hiding this comment.
Yes, something like that. Maybe we should specify that the 'later' part is in the other dependency.
There was a problem hiding this comment.
I updated the last sentence with a more thorough explanation. We also need to update the links but that can only be done when #250 is done.
|
I think some things need to be clarified in the docs before we can merge this. |
Co-authored-by: Frederik Gheysels <[email protected]>
Besides the open comment, something else? |
…ttps://github.com/stijnmoreels/arcus.observability into feature/add-dependency-id-to-az-keyvault-dependency
Add dependency ID method overload for tracking Azure Key Vault dependencies.
Relates to #243