Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - IoT/Sql separate connection string tracking in diff libraries #130

Merged
merged 3 commits into from
Jul 3, 2020
Merged

Feature - IoT/Sql separate connection string tracking in diff libraries #130

merged 3 commits into from
Jul 3, 2020

Conversation

stijnmoreels
Copy link
Member

Closes #109

@stijnmoreels stijnmoreels requested a review from tomkerkhove as a code owner July 3, 2020 07:22
@stijnmoreels
Copy link
Member Author

Also, before merging: I had a question here.

tomkerkhove
tomkerkhove suggested changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we cannot delete the current SQL extensions that we already have

src/Arcus.Observability.Telemetry.Core/Extensions/ILoggerExtensions.cs Show resolved Hide resolved
src/Arcus.Observability.Telemetry.Core/Extensions/ILoggerExtensions.cs Show resolved Hide resolved
@stijnmoreels stijnmoreels mentioned this pull request Jul 3, 2020
Closed
@stijnmoreels stijnmoreels merged commit b5dab2e into arcus-azure:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees

@stijnmoreels stijnmoreels

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide capability to track a IoT Hub dependency based on connection string information
2 participants
@stijnmoreels @tomkerkhove