Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track exceptions to Azure Application Insights #115

Merged
merged 6 commits into from
May 15, 2020
Merged

Track exceptions to Azure Application Insights #115

merged 6 commits into from
May 15, 2020

Conversation

tomkerkhove
Copy link
Contributor

Signed-off-by: Tom Kerkhove [email protected]

Closes #113

@tomkerkhove tomkerkhove requested a review from stijnmoreels as a code owner May 14, 2020 14:56
@tomkerkhove
Copy link
Contributor Author

Let's have a look at those tests 🤔

stijnmoreels
stijnmoreels approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@stijnmoreels stijnmoreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thing you found it! Thanks! 💯

@tomkerkhove tomkerkhove merged commit 03e6473 into arcus-azure:master May 15, 2020
@tomkerkhove tomkerkhove deleted the track-exceptions branch May 15, 2020 06:43
@stijnmoreels stijnmoreels mentioned this pull request Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stijnmoreels stijnmoreels stijnmoreels approved these changes

Assignees

@stijnmoreels stijnmoreels

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Application Insights sink is not correctly tracking exceptions
2 participants
@tomkerkhove @stijnmoreels