Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KubernetesEnricher's example table in docs is not supported in Jekyll docs #86

Closed
stijnmoreels opened this issue Apr 20, 2020 · 0 comments · Fixed by #87
Closed

KubernetesEnricher's example table in docs is not supported in Jekyll docs #86

stijnmoreels opened this issue Apr 20, 2020 · 0 comments · Fixed by #87
Labels
documentation All issues related to documentation enrichers All issues related to Serilog enrichers to automatically provide contextual information help wanted Extra attention is needed serilog All issues related to Serilog
Milestone
v0.1.1

Comments

@stijnmoreels
Copy link
Member

Describe the bug
The docs for the KubernetesEnricher has a markdown table as an example, but the docs doesn't represent this correclty.

To Reproduce
Go to: https://observability.arcus-azure.net/features/telemetry-enrichment#kubernetes-enricher.

Expected behavior
A table is shown with the example data.
@stijnmoreels stijnmoreels added documentation All issues related to documentation help wanted Extra attention is needed serilog All issues related to Serilog enrichers All issues related to Serilog enrichers to automatically provide contextual information labels Apr 20, 2020
@stijnmoreels stijnmoreels added this to the v0.2 milestone Apr 20, 2020
@stijnmoreels stijnmoreels changed the title Tables not supported in Jekyll KubernetesEnricher's example table in docs is not supported in Jekyll docs Apr 20, 2020
tomkerkhove added a commit that referenced this issue Apr 20, 2020
@tomkerkhove
Fix broken table
8875173 
Closes #86
@tomkerkhove tomkerkhove mentioned this issue Apr 20, 2020
Merged
stijnmoreels pushed a commit that referenced this issue Apr 20, 2020
@tomkerkhove
Fix broken table (#87)
5c01beb 
Closes #86
@tomkerkhove tomkerkhove modified the milestones: v0.2, v0.1.1 Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation All issues related to documentation enrichers All issues related to Serilog enrichers to automatically provide contextual information help wanted Extra attention is needed serilog All issues related to Serilog
Projects
None yet
Milestone
v0.1.1
Development

Successfully merging a pull request may close this issue.

Fix broken table arcus-azure/arcus.observability
2 participants
@tomkerkhove @stijnmoreels