Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract application/component name into a service so that both Arcus' Serilog as well as Microsoft TelemetryClient can benefit from this #470

Closed
stijnmoreels opened this issue Oct 12, 2022 · 0 comments · Fixed by #472
Closed

Extract application/component name into a service so that both Arcus' Serilog as well as Microsoft TelemetryClient can benefit from this #470

stijnmoreels opened this issue Oct 12, 2022 · 0 comments · Fixed by #472
Assignees
@stijnmoreels
Labels
app-information All issues related to information concerning the application application-insights All issues related to Azure Application Insights enrichers All issues related to Serilog enrichers to automatically provide contextual information
Milestone
v2.7.0

Comments

@stijnmoreels
Copy link
Member

Is your feature request related to a problem? Please describe.
When combining Arcus Serilog Application Insights sink and Microsoft's TelemetryClient, the application/component name is different or duplicated because Arcus works with enrichers to assign a component name and the TelemetryClient requires a registered ITelemetryInitializer.

Describe the solution you'd like
Extract the application/component name into a service so that both Arcus' Serilog as well as the Microsoft TelemetryClient can benefit from this and we only have to configure this once.
@stijnmoreels stijnmoreels added application-insights All issues related to Azure Application Insights enrichers All issues related to Serilog enrichers to automatically provide contextual information app-information All issues related to information concerning the application labels Oct 12, 2022
@stijnmoreels stijnmoreels added this to the v2.7.0 milestone Oct 12, 2022
@stijnmoreels stijnmoreels self-assigned this Oct 12, 2022
This was referenced Oct 12, 2022
Merged
Merged
@stijnmoreels stijnmoreels mentioned this issue Nov 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stijnmoreels stijnmoreels

Labels
app-information All issues related to information concerning the application application-insights All issues related to Azure Application Insights enrichers All issues related to Serilog enrichers to automatically provide contextual information
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging a pull request may close this issue.

feat: add re-usable application name stijnmoreels/arcus.observability
1 participant
@stijnmoreels