Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: audit remediations #569

Merged
merged 5 commits into from
May 16, 2024
Merged

fix: audit remediations #569

merged 5 commits into from
May 16, 2024

Conversation

spoo-bar
Copy link
Contributor

@spoo-bar spoo-bar commented May 14, 2024 •
edited
Loading

Addressed the following:

  • Move cwerrors endblocker to the end of all the endblocker invocations
  • Documentation updates for x/cwerrors
  • Documentation updates for x/cwica
  • Some code cleanup of removing unused enums and values

@spoo-bar spoo-bar marked this pull request as ready for review May 14, 2024 13:21
@spoo-bar spoo-bar requested a review from a team as a code owner May 14, 2024 13:21
@spoo-bar spoo-bar requested a review from aelesbao May 14, 2024 13:21
zanicar
zanicar approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@zanicar zanicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spoo-bar spoo-bar merged commit 8f11848 into main May 16, 2024
10 checks passed
@spoo-bar spoo-bar deleted the spoorthi/audit-remediations branch May 16, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanicar zanicar zanicar approved these changes

@aelesbao aelesbao Awaiting requested review from aelesbao aelesbao is a code owner automatically assigned from archway-network/protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spoo-bar @zanicar