Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/cwerrors): audit remediations #564

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Conversation

spoo-bar
Copy link
Contributor

  • Ensuring user doesnt overpay for contract subscriptions
  • When user resubscribes to error callback(before the existing subscription ends), extend the subscription end date instead of resetting the end date
  • Removing some redundant values stored in the module collections (when value is part of the key)

@spoo-bar spoo-bar marked this pull request as ready for review April 25, 2024 11:43
@spoo-bar spoo-bar requested a review from a team as a code owner April 25, 2024 11:43
@spoo-bar spoo-bar requested a review from aelesbao April 25, 2024 11:43
Copy link
Contributor

@zanicar zanicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spoo-bar spoo-bar merged commit 92fa62e into main Apr 25, 2024
8 of 9 checks passed
@spoo-bar spoo-bar deleted the spoorthi/audit-remediations branch April 25, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants