Fix arguments being initialized twice for tenants:seed command #611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel >= 8.32 introduced a new argument to the seed command see laravel/framework#36513.
This is causing our extended tenants:seed command to initialize the options and arguments twice which throws an exception because at the point we call the
specifyParameters
method in the constructor it has already instanciated the arguments once so the newclass
argument is already present.This pr fixes that by removing our call to the
specifyParameters
method on the constructor sense it's already being called in the parent constructor anyway and the only thing we are really doing is specifying one additional option to the command anyway.