Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize license headers; resolves #51. #57

Merged
merged 2 commits into from
Sep 5, 2018
Merged

Normalize license headers; resolves #51. #57

merged 2 commits into from
Sep 5, 2018

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Sep 5, 2018

GitHub issue(s): #51

What does this Pull Request do?

  • Update license header in all src files.
  • Update README
  • Rename LICENSE.txt to LICENSE
  • Make LICENSE consistent with other AU projects

How should this be tested?

TravisCI should take care of it.

Additional Notes:

Updated version of #56

- Update license header in all src files.
- Update README
- Rename LICENSE.txt to LICENSE
- Make LICENSE consistent with other AU projects
Copy link
Member

@ianmilligan1 ianmilligan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me (and 🎉 on the TravisCI).

@ruebot
Copy link
Member Author

ruebot commented Sep 5, 2018

Huh. CodeCov is still being wonky.

@ruebot
Copy link
Member Author

ruebot commented Sep 5, 2018

Oh, duh. We're not producing any type of coverage report for CodeCov to look at. 🤦‍♂️

I'll create a ticket for that.

@greebie
Copy link
Collaborator

greebie commented Sep 5, 2018

This lgtm. @ruebot the codecov issue is separate from this PR right? I can merge now I'm happy?

@ruebot
Copy link
Member Author

ruebot commented Sep 5, 2018

Yep. CodeCov is separate. Feel free to merge this one if you're good with the license modifications.

@greebie greebie merged commit b1f8eec into archivesunleashed:master Sep 5, 2018
@ruebot ruebot deleted the issue-51 branch September 5, 2018 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants