Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import NetBSD/src/usr.sbin/mtree in place of pkgsrc'd version. #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jashank
Copy link

@jashank jashank commented Apr 21, 2022

The mtree(8) implementation in pkgsrc has languished; meanwhile, a range of features have been added to the implementation in the NetBSD source tree, and AFAICT that's now the authoritative source (for instance, FreeBSD imports this, not the pkgsrc version).

Whilst here, switch to tracking src/usr.sbin/mtree CVS. The resulting cvs diff to this tree is now only compatibility fixes.

Whilst here, update stat_flags.c, now in NetBSD/src/lib/libutil; previously, mtree2nbcompat picked it up from NetBSD/src/bin/ls, but it moved in 2006.

Whilst here, update pack_dev.[ch] from NetBSD/src/sbin/mknod.

Whilst here, import (and refresh) Debian's copyright file, which gives provenance for all the files.

Whilst here, mark the CVS timestamp at which src/usr.sbin/mtree was last modified (to wit, 2021-04-03) --- how I wish there were reliable atomic version numbers on that repo! (It'd be nice to use NetBSD's version numbering as a reference marker.)

Whilst here, update mtree.5 from libarchive/libarchive.

Whilst here, autoupdate to bump configure.ac.

The mtree(8) implementation in pkgsrc has languished; meanwhile, a range
of features have been added to the implementation in the NetBSD source
tree, and AFAICT that's now the authoritative source (for instance,
FreeBSD imports this, not the pkgsrc version).

Whilst here, switch to tracking `src/usr.sbin/mtree' CVS.  The resulting
`cvs diff' to this tree is now only compatibility fixes.

Whilst here, update `stat_flags.c', now in `NetBSD/src/lib/libutil';
previously, `mtree2nbcompat' picked it up from `NetBSD/src/bin/ls',
but it moved in 2006.

Whilst here, update `pack_dev.[ch]' from `NetBSD/src/sbin/mknod'.

Whilst here, import (and refresh) Debian's copyright file, which gives
provenance for all the files.

Whilst here, mark the CVS timestamp at which `src/usr.sbin/mtree' was
last modified (to wit, 2021-04-03) --- how I wish there were reliable
atomic version numbers on that repo!  (It'd be nice to use NetBSD's
version numbering as a reference marker.)

Whilst here, update `mtree.5' from libarchive/libarchive.

Whilst here, `autoupdate' to bump `configure.ac'.

Signed-off-by: Jashank Jeremy <[email protected]>
@archiecobbs
Copy link
Owner

While I heartily applaud this effort, this patch is way too large for me to review.

In order to keep things straight and minimize disruption, I suggest instead we create a new branch or even better a new project (nmtree2?) for this flavor of the utility.

Your thoughts?

@jashank
Copy link
Author

jashank commented May 2, 2022

Either of those options sound reasonable to me. I'm happy to try to put together a repository.

@archiecobbs
Copy link
Owner

OK that sounds good.

I tried to fork nmtree to nmtree2 under my name but github doesn't allow this.

Instead, if you don't mind hosting it, please fork nmtree to nmtree2 under your name, and then apply your patch. This way we'll keep a relationship between the two code bases. Feel free to make add me as a maintainer as well.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants