Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the url datatype tile transformation, #9523 #9825

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Update the url datatype tile transformation, #9523 #9825

merged 2 commits into from
Jul 26, 2023

Conversation

njkim
Copy link
Collaborator

@njkim njkim commented Jul 24, 2023

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

When only the url was given, the transform_for_tile will return the value as an object form, even when it fails all the transformations.

Issues Solved

#9523

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Ticket Background

  • Sponsored by:
  • Found by: @
  • Tested by: @
  • Designed by: @

Further comments

@njkim njkim requested a review from chiatt July 24, 2023 21:27
chiatt
chiatt approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chiatt chiatt merged commit 2cfb73d into dev/7.4.x Jul 26, 2023
@chiatt chiatt deleted the 9824_url_datatype_tile_transformation branch July 26, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiatt chiatt chiatt approved these changes

Assignees

@chiatt chiatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njkim @chiatt