Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bulk load performance, #9670 #9714

Merged
merged 7 commits into from
Jul 20, 2023

Conversation

njkim
Copy link
Collaborator

@njkim njkim commented Jul 3, 2023

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Improve the performance & logic report to the front end of the bulk editor by

  • not checking cardinality errors (since editor does not change the number of tiles)
  • improve the cardinality checking db function
  • trying catching errors after the load (before index)

Issues Solved

#9669, #9670, #9671

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Ticket Background

  • Sponsored by:
  • Found by: @
  • Tested by: @
  • Designed by: @

Further comments

@njkim njkim changed the base branch from master to dev/7.4.x July 3, 2023 23:06
@njkim njkim requested a review from apeters July 3, 2023 23:07
Copy link
Member

@apeters apeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants