Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

purges count method in favor of exists #9703

Merged
merged 1 commit into from
Jul 4, 2023
Merged

purges count method in favor of exists #9703

merged 1 commit into from
Jul 4, 2023

Conversation

aarongundel
Copy link
Contributor

purges count in favor of exists (where logical) to improve performance.

@aarongundel aarongundel requested a review from chiatt June 29, 2023 20:06
@aarongundel aarongundel linked an issue Jun 29, 2023 that may be closed by this pull request
replace count() when used for existence checking #9702
Closed
chiatt
chiatt approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chiatt chiatt merged commit 5b13061 into dev/7.4.x Jul 4, 2023
@chiatt chiatt deleted the 9702-exists branch July 4, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiatt chiatt chiatt approved these changes

Assignees

@chiatt chiatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace count() when used for existence checking
2 participants
@aarongundel @chiatt