Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7413 adv search collapse #7414

Merged
merged 3 commits into from
May 12, 2021
Merged

7413 adv search collapse #7414

merged 3 commits into from
May 12, 2021

Conversation

whatisgalen
Copy link
Member

@whatisgalen whatisgalen commented May 11, 2021

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Issues Solved

addresses #7413

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Ticket Background

  • Sponsored by:
  • Found by: @
  • Tested by: @
  • Designed by: @

Further comments

Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement and works as expected. A nice improvement would be to add 'expand all' and 'collapse all' buttons to the top of the list. I've created a ticket for this enhancement: #7419

@chiatt chiatt merged commit 40f5386 into stable/5.2.x May 12, 2021
@chiatt chiatt deleted the 7413_adv_search_collapse branch May 12, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants