Fix error when cycling the dropdown filter options in advanced search #11442 #11706
+8
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the error report, cyling between "references" and "does not reference" produce a "NoneType is not iterable" error. This was due to the fact that when a value is selected in the dropdown, the value is set to null if the string is an empty string.
Types of changes
Description of Change
Cycling between "references" and "does not reference" produces a "NoneType is not iterable" error.
This was due to the fact that when a value is selected in the drop-down, the value is set to null if the string
is an empty string. In the example provided in the issue report, the "references" entry has an id of "".
Upon selecting it, the
change
event is fired and the value is set to null.This PR removes the logic that converted the empty string to null when the
change
event is fired.Issues Solved
Closes #11442
Checklist