Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7419 resource model expand collapse all #11663

Open
wants to merge 8 commits into
base: dev/8.0.x
Choose a base branch
from

Conversation

vouidaskis
Copy link
Contributor

@vouidaskis vouidaskis commented Dec 2, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Add expand all and collapse all buttons to the top of the list much like the node tree in the graph designer.

Issues Solved

Closes #7419

Checklist

  • I targeted one of these branches:
    • dev/8.0.x (under development): features, bugfixes not covered below
    • dev/7.6.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

@vouidaskis vouidaskis force-pushed the 7419_resource_model_expand_collapse_all branch from bc9e7fd to 81b05fb Compare December 5, 2024 15:21
@vouidaskis vouidaskis requested a review from a team as a code owner December 5, 2024 15:21
@vouidaskis vouidaskis changed the base branch from dev/7.6.x to dev/8.0.x December 5, 2024 15:22
@chiatt chiatt requested review from chiatt and removed request for a team December 5, 2024 18:11
@chiatt chiatt self-assigned this Dec 5, 2024
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this fix @vouidaskis. Could you add just a little space between the expand and collapse buttons?
image

They should look more consistent with the similar feature in the graph and card trees:
image

@chiatt chiatt assigned apeters and unassigned chiatt Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add expand all and collapse all buttons to resource model headers in adv search
3 participants