Fix display value for resource-instance-list datatypes #11641 #11642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
commented
Nov 20, 2024
Comment on lines
-258
to
+276
| # TODO: remove mock, fix underlying functionality to not | ||
| # requery for Resource objects yet again in get_display_value(). | ||
| with self.assertNumQueries(1): | ||
| json = ri_list.to_json(tile, node) | ||
| self.assertEqual(json, self.mock_display_value) | ||
| # Was 4, is now 3, should be 1-2 after fixing: | ||
| # https://github.com/archesproject/arches/issues/11632 | ||
| with self.assertNumQueries(3): |
There was a problem hiding this comment.
This was 1 query before because I was mocking all of compile_json. But now that I'm only mocking displayname, we're hitting the extra queries mentioned in the folllow-up issue. So I left a comment that it was 4 before the commit that caused me to pop the hood on this.
aarongundel
approved these changes
Nov 20, 2024
Done! Thanks for finding & for the speedy review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
Fix unreleased regression in eb85d10
Issues Solved
Closes #11641
Checklist
Ticket Background