Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds resource geoutils #11507 #11508

Closed
wants to merge 7 commits into from
Closed

adds resource geoutils #11507 #11508

wants to merge 7 commits into from

Conversation

chrabyrd
Copy link
Contributor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

I DO NOT EXPECT THIS TO BE MERGED INTO THE 7.6 release. This is a sister ticket to https://github.com/fargeo/ca-shpo-online/pull/159

Issues Solved

Closes #11507

@jacobtylerwalls jacobtylerwalls linked an issue Sep 28, 2024 that may be closed by this pull request
Add geoutils for buffering and finding resources within a feature collection #11507
Open
@chrabyrd chrabyrd requested a review from robgaston September 30, 2024 22:10
@chrabyrd chrabyrd assigned robgaston and unassigned apeters Sep 30, 2024
robgaston
robgaston requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@robgaston robgaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these functions look generally good (a few comments on get_intersection_and_difference_of_feature_collections) and I think they should go into core as built here. I'd say go ahead and write those tests so we can merge this in. thanks!

arches/app/utils/geo_utils.py Show resolved Hide resolved
arches/app/utils/geo_utils.py Show resolved Hide resolved
@chrabyrd
Copy link
Contributor Author

chrabyrd commented Oct 2, 2024

closing in favor of moving geoutils to SHPO. These can/will be re-introduced to core on an as-need basis

@chrabyrd chrabyrd closed this Oct 2, 2024
@chiatt chiatt deleted the 11507-cbyrd-add-resource-geoutils branch November 12, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtylerwalls jacobtylerwalls jacobtylerwalls left review comments

@robgaston robgaston robgaston requested changes

@apeters apeters Awaiting requested review from apeters

Assignees

@robgaston robgaston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add geoutils for buffering and finding resources within a feature collection
4 participants
@chrabyrd @robgaston @jacobtylerwalls @apeters