Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra get_relations ORM queries #11460

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Remove extra get_relations ORM queries #11460

merged 4 commits into from
Sep 17, 2024

Conversation

whatisgalen
Copy link
Member

@whatisgalen whatisgalen commented Sep 16, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Issues Solved

Closes #11459

Checklist

  • I targeted one of these branches:
    • dev/7.6.x (under development): features, bugfixes not covered below
    • dev/7.5.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Ticket Background

  • Sponsored by:
  • Found by: @
  • Tested by: @
  • Designed by: @

Further comments

@whatisgalen whatisgalen changed the title rm extra get_relations call for each rel resource, re #11459 Remove extra get_relations ORM queries Sep 16, 2024
@whatisgalen whatisgalen changed the title Remove extra get_relations ORM queries Remove extra get_relations ORM queries Sep 16, 2024
whatisgalen added a commit that referenced this pull request Sep 16, 2024
@apeters
Copy link
Member

apeters commented Sep 17, 2024

Haven't tested this yet, but on first glance this looks like a nice improvement.

@whatisgalen
Copy link
Member Author

Haven't tested this yet, but on first glance this looks like a nice improvement.

Thanks! I think there's potentially a more in-depth improvement beyond these changes that would separate backend logic used by the related-resources manager/search filter from the report's need to get related resources. However that's likely better suited for a PR against dev/8.0.x.

@apeters apeters self-requested a review September 17, 2024 22:14
Copy link
Member

@apeters apeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@apeters apeters merged commit 64e222f into dev/7.6.x Sep 17, 2024
7 checks passed
@apeters apeters deleted the 11459_rr_slowdown2 branch September 17, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants