Adds generic search thumbnail retrieval #10266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiatt
requested changes
Nov 14, 2023
| @@ -66,6 +66,7 @@ | |||
|
|
|||
| ELASTICSEARCH_HTTP_PORT = 9200 # this should be in increments of 200, eg: 9400, 9600, 9800 | |||
| SEARCH_BACKEND = "arches.app.search.search.SearchEngine" | |||
| SEARCH_THUMBNAILS = False | |||
There was a problem hiding this comment.
This should also be added to the project template's settings file
arches/app/views/thumbnail.py
Outdated
| @@ -0,0 +1,34 @@ | |||
| from arches.app.models.resource import Resource | |||
arches/app/views/thumbnail.py
Outdated
| from arches.app.models.resource import Resource | ||
| from django.views.generic import View | ||
| from django.http import HttpResponse, HttpResponseNotFound | ||
| from django.utils.translation import get_language |
arches/app/views/thumbnail.py
Outdated
| from django.views.generic import View | ||
| from django.http import HttpResponse, HttpResponseNotFound | ||
| from django.utils.translation import get_language | ||
| import requests |
| @@ -0,0 +1,39 @@ | |||
| from logging import Logger | |||
There was a problem hiding this comment.
it is used on line 17
There was a problem hiding this comment.
On 17 you are using 'logging' which is defined on line 8 imported from line 2. Logger itself is unused. I wouldn't have caught it myself had vscode not flagged it.
chiatt
approved these changes
Nov 27, 2023
| @@ -0,0 +1,16 @@ | |||
| import base64 | |||
There was a problem hiding this comment.
It's nice to have an example, but because this file isn't yet wired in as a default, I think it would be better to remove this here and add it to the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds search thumbnails - to be implemented at the project level.