Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resources are incorrectly deleted when PUTing a JSON-LD file without supplying either a graph id or graph slug. #9968

Closed
apeters opened this issue Aug 28, 2023 · 0 comments
Closed

Resources are incorrectly deleted when PUTing a JSON-LD file without supplying either a graph id or graph slug. #9968

apeters opened this issue Aug 28, 2023 · 0 comments
Assignees
@apeters
Labels
API Type: Bug Something isn't working

Comments

@apeters
Copy link
Member

apeters commented Aug 28, 2023

If a user doesn't supply either a graph id or graph slug, then the system should respond back with a meaningful error message and should not delete the resource from the system.
@apeters apeters added Type: Bug Something isn't working API labels Aug 28, 2023
@apeters apeters self-assigned this Aug 28, 2023
@chiatt chiatt added this to pipeline Aug 28, 2023
@ekansa ekansa mentioned this issue Aug 28, 2023
Merged
3 tasks
apeters added a commit that referenced this issue Aug 28, 2023
@apeters
fixes bug where not supplying a graphid or slug to the json-ld api wo…
87987de 
…uld delete the resource but not save the new one, re #9968
@apeters apeters mentioned this issue Aug 28, 2023
Merged
apeters added a commit that referenced this issue Aug 29, 2023
@apeters
only json-ld format requires a slug or graphid in the PUT or POST req…
678b124 
…uest url, re #9968
apeters added a commit that referenced this issue Aug 29, 2023
@apeters
nit, re #9968
491ba7e
chiatt added a commit that referenced this issue Aug 30, 2023
@chiatt
Merge pull request #9969 from archesproject/9968_jsonld_PUT_bug
c46a919 
fixes bug where not supplying a graphid or slug to the json-ld api would delete the resource but not save the new one, re #9968
@chiatt chiatt closed this as completed Aug 30, 2023
@github-project-automation github-project-automation bot moved this to ✅ Done in pipeline Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apeters apeters

Labels
API Type: Bug Something isn't working
Projects
pipeline
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apeters @chiatt