Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrides of admin templates not found in 7.6 #11668

Closed
jacobtylerwalls opened this issue Dec 3, 2024 · 0 comments
Closed

Overrides of admin templates not found in 7.6 #11668

jacobtylerwalls opened this issue Dec 3, 2024 · 0 comments
Assignees
Labels
Type: Bug Something isn't working

Comments

@jacobtylerwalls
Copy link
Member

In 7.6, as part of finalizing arches applications patterns, we ordered INSTALLED_APPS such that core arches always comes last:

arches/arches/settings.py

Lines 381 to 383 in 3050821

# Placing this last ensures any templates provided by Arches Applications
# take precedence over core arches templates in arches/app/templates.
INSTALLED_APPS += ("arches.app",)

However, this has the effect of ignoring core arches's own overrides of the Django admin templates, e.g. the reset password form at templates/registration/reset_password_form.html, because django.contrib.admin is near the top of the ordered installed apps.

Demo

Expected:
Screenshot 2024-12-03 at 12 44 57 PM

Actual:

Screenshot 2024-12-03 at 12 45 27 PM

Discussion

Should we simply order django.contrib.admin last? This will require user action, which we don't like to do in patches. There might be a way to simply prepend the directory with these specific overrides inside our build_templates_config() hook?

cc/ @chrabyrd

@jacobtylerwalls jacobtylerwalls added Type: Bug Something isn't working Priority: High labels Dec 3, 2024
@chiatt chiatt added this to pipeline Dec 3, 2024
@njkim njkim self-assigned this Dec 6, 2024
njkim added a commit that referenced this issue Dec 6, 2024
chrabyrd added a commit that referenced this issue Dec 12, 2024
chrabyrd added a commit that referenced this issue Dec 12, 2024
chrabyrd added a commit that referenced this issue Dec 12, 2024
chiatt pushed a commit that referenced this issue Dec 12, 2024
* fixes arches-level template overrides #11668
@github-project-automation github-project-automation bot moved this to ✅ Done in pipeline Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants