Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query browser setting for dark mode and provide it with base-root.htm #11624

Closed
jacobtylerwalls opened this issue Nov 14, 2024 · 0 comments · Fixed by #11667
Closed

Query browser setting for dark mode and provide it with base-root.htm #11624

jacobtylerwalls opened this issue Nov 14, 2024 · 0 comments · Fixed by #11667
Assignees
@jacobtylerwalls

Comments

@jacobtylerwalls
Copy link
Member

I believe it ended up being that some of this logic gets moved to core. Essentially the logic to derive the user scheme preference and set it on the <html> element. I believe part of that work was to set a small entry in localStorage so the userPreference/toggleState is persisted through refreshes.

The rest -- supporting multiple scheme preferences and adding a column to the UserProfile table -- were punted

Originally posted by @chrabyrd in archesproject/arches-lingo#91 (comment)
@chiatt chiatt added this to pipeline Nov 14, 2024
@jacobtylerwalls jacobtylerwalls moved this to 🔖 Ready in pipeline Nov 14, 2024
@jacobtylerwalls jacobtylerwalls moved this from 🔖 Ready to 👀 In Review in pipeline Dec 3, 2024
@jacobtylerwalls jacobtylerwalls self-assigned this Dec 3, 2024
jacobtylerwalls added a commit that referenced this issue Dec 3, 2024
@jacobtylerwalls
Add system dark mode detection for Vue apps #11624
143b026
jacobtylerwalls added a commit that referenced this issue Dec 3, 2024
@jacobtylerwalls
Add system dark mode detection for Vue apps #11624
0fff51b
@jacobtylerwalls jacobtylerwalls mentioned this issue Dec 3, 2024
Merged
11 tasks
jacobtylerwalls added a commit that referenced this issue Dec 3, 2024
@jacobtylerwalls
Add system dark mode detection for Vue apps #11624 (#11667)
3050821
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Dec 3, 2024
jacobtylerwalls added a commit that referenced this issue Dec 3, 2024
@jacobtylerwalls
Handle custom selectors in dark mode query re #11624
ce61abe
jacobtylerwalls added a commit that referenced this issue Dec 3, 2024
@jacobtylerwalls
Handle custom selectors in dark mode query re #11624 (#11671)
1a90bdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
None yet
Projects
pipeline
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add system dark mode detection for Vue apps #11624 archesproject/arches
1 participant
@jacobtylerwalls