Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource.get_related_resources should cache preflabel lookups for relationshiptype #11583

Closed
whatisgalen opened this issue Oct 28, 2024 · 0 comments · Fixed by #11584
Closed

Resource.get_related_resources should cache preflabel lookups for relationshiptype #11583

whatisgalen opened this issue Oct 28, 2024 · 0 comments · Fixed by #11584
Assignees
@whatisgalen

Comments

@whatisgalen
Copy link
Member

whatisgalen commented Oct 28, 2024 •
edited
Loading

there's an ES query to the concept index once for each relationship preflabel lookup even if it's already been looked up. For a few hundred related resources, this can look like 30seconds to load a report
@chiatt chiatt added this to pipeline Oct 28, 2024
whatisgalen added a commit that referenced this issue Oct 28, 2024
@whatisgalen
cache already looked up relationship preflabels in Resource.get_relat…
9007af9 
…ed_resources, re #11583
@whatisgalen whatisgalen mentioned this issue Oct 28, 2024
Merged
11 tasks
@whatisgalen whatisgalen self-assigned this Oct 28, 2024
whatisgalen added a commit that referenced this issue Nov 1, 2024
@whatisgalen
swap negative check of dict for postivie, re #11583
07fb6d6
whatisgalen added a commit that referenced this issue Nov 14, 2024
@whatisgalen
create a test for Resource.get_related_resources, re #11583
3fe4759
whatisgalen added a commit that referenced this issue Nov 14, 2024
@whatisgalen
manually import other graphs needed for test, re #11583
b8ae747
whatisgalen added a commit that referenced this issue Nov 14, 2024
@whatisgalen
include user kwarg in get_related_resources, re #11583
7aa7b41
whatisgalen added a commit that referenced this issue Nov 14, 2024
@whatisgalen
use graph_fixtures convention, add location to test settings, re #11583
c0e2f43
whatisgalen added a commit that referenced this issue Nov 14, 2024
@whatisgalen
rm unused imports, re #11583
8792f60
whatisgalen added a commit that referenced this issue Nov 14, 2024
@whatisgalen
add release note, re #11583
2b44eb6
@whatisgalen whatisgalen linked a pull request Nov 14, 2024 that will close this issue
11583 leverage cache for related resource relationship preflabel lookup #11584
Merged
11 tasks
chiatt pushed a commit that referenced this issue Nov 15, 2024
@whatisgalen
11583 leverage cache for related resource relationship preflabel look…
429603e 
…up (#11584)

* cache already looked up relationship preflabels in Resource.get_related_resources, re #11583
* add release note, re #11583
@chiatt chiatt closed this as completed Nov 15, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in pipeline Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whatisgalen whatisgalen

Labels
None yet
Projects
pipeline
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

11583 leverage cache for related resource relationship preflabel lookup archesproject/arches
2 participants
@chiatt @whatisgalen