Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES dsl query can't be serialized to json #11386

Closed
whatisgalen opened this issue Aug 22, 2024 · 1 comment · Fixed by #11387
Closed

ES dsl query can't be serialized to json #11386

whatisgalen opened this issue Aug 22, 2024 · 1 comment · Fixed by #11387
Labels
Type: Bug Something isn't working

Comments

@whatisgalen
Copy link
Member

whatisgalen commented Aug 22, 2024 •
edited
Loading

when the returnDsl=True kwarg is passed, the dsl, i.e. the elasticsearch DSL-based classes that make up a query object, shouldn't be serialized to json as our json serializer doesn't currently support that. It should be sent as an unserialized instance of a query object
@chiatt chiatt added this to pipeline Aug 22, 2024
whatisgalen added a commit that referenced this issue Aug 22, 2024
@whatisgalen
return dsl unserialized, re #11386
12c0159
@whatisgalen whatisgalen mentioned this issue Aug 22, 2024
Merged
11 tasks
@whatisgalen whatisgalen added the Type: Bug Something isn't working label Aug 22, 2024
@whatisgalen whatisgalen linked a pull request Aug 22, 2024 that will close this issue
return dsl unserialized, re #11386 #11387
Merged
11 tasks
whatisgalen added a commit that referenced this issue Aug 22, 2024
@whatisgalen
create test for returnDsl, re #11386
836ef36
whatisgalen added a commit that referenced this issue Aug 22, 2024
@whatisgalen
dont directly return dsl until search_results finishes handle_search_…
3b7b362 
…results_query, re #11386
whatisgalen added a commit that referenced this issue Aug 22, 2024
@whatisgalen
set default of None for search_query_object.pop(query) in returnDsl, re
253a01e 
#11386
njkim added a commit that referenced this issue Aug 23, 2024
@njkim
Merge pull request #11387 from archesproject/11386_dsl_unserialized
f67721f 
return dsl unserialized, re #11386
@whatisgalen
Copy link
Member Author

fixed by #11387

@github-project-automation github-project-automation bot moved this to ✅ Done in pipeline Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
pipeline
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

return dsl unserialized, re #11386 archesproject/arches
1 participant
@whatisgalen