Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test runner fails when given a subset of tests that don't use the database #11204

Closed
jacobtylerwalls opened this issue Jul 18, 2024 · 0 comments · Fixed by #11205
Closed

Test runner fails when given a subset of tests that don't use the database #11204

jacobtylerwalls opened this issue Jul 18, 2024 · 0 comments · Fixed by #11205
Assignees
@jacobtylerwalls

Comments

@jacobtylerwalls
Copy link
Member

When running a partial set of tests that do not use postgres,

  • e.g. because they inherit from SimpleTestCase
  • or it's a new project and you delete the sample test provided by the template

ArchesTestRunner attempts to perform additional setup actions against the db anyway.

Suggest adding a guard to skip our custom, additional db setup when Django decides to skip database setup entirely:

Skipping setup of unused database(s): default.
@jacobtylerwalls jacobtylerwalls self-assigned this Jul 18, 2024
@jacobtylerwalls jacobtylerwalls changed the title Test runner fails when given a subset of tests don't use the database Test runner fails when given a subset of tests that don't use the database Jul 18, 2024
@chiatt chiatt added this to pipeline Jul 18, 2024
@jacobtylerwalls jacobtylerwalls moved this to 🏗 In Progress in pipeline Jul 18, 2024
jacobtylerwalls added a commit to archesproject/arches-templating that referenced this issue Jul 18, 2024
@jacobtylerwalls
Anticipate fix for archesproject/arches#11204
9c48130
jacobtylerwalls added a commit that referenced this issue Jul 18, 2024
@jacobtylerwalls
Allow running tests without PG on unmigrated db #11204
c5a664d
jacobtylerwalls added a commit that referenced this issue Jul 18, 2024
@jacobtylerwalls
Allow running tests without PG on unmigrated db #11204
8efdba0
@jacobtylerwalls jacobtylerwalls mentioned this issue Jul 18, 2024
Merged
11 tasks
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In Progress to 👀 In Review in pipeline Jul 18, 2024
@jacobtylerwalls jacobtylerwalls linked a pull request Jul 18, 2024 that will close this issue
Allow running tests without PG on unmigrated db #11204 #11205
Merged
11 tasks
chiatt pushed a commit that referenced this issue Jul 30, 2024
@jacobtylerwalls @chiatt
Allow running tests without PG on unmigrated db #11204
51d3ec1
@chiatt chiatt closed this as completed Jul 30, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
None yet
Projects
pipeline
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow running tests without PG on unmigrated db #11204 archesproject/arches
2 participants
@chiatt @jacobtylerwalls