nit #11567

archesproject · Oct 23, 2024 · fbed86e · fbed86e
1 parent ba72150
commit fbed86e
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 1 deletion.
diff --git a/arches/app/src/arches/utils/generate-arches-url.test.ts b/arches/app/src/arches/utils/generate-arches-url.test.ts
@@ -0,0 +1,43 @@
+import { describe, it, expect } from "vitest";
+import generateArchesURL from "@/arches/utils/generate-arches-url.ts";
+
+// @ts-expect-error  ARCHES_URLS is defined globally
+global.ARCHES_URLS = {
+    example_url: "/admin/{language_code}/example/{id}",
+    another_url: "/admin/another/{id}",
+};
+
+describe("generateArchesURL", () => {
+    it("should return a valid URL with language code and parameters", () => {
+        const result = generateArchesURL("example_url", "fr", { id: "123" });
+        expect(result).toBe("/admin/fr/example/123");
+    });
+
+    it("should use the <html> lang attribute when no language code is provided", () => {
+        Object.defineProperty(document.documentElement, "lang", {
+            value: "de",
+            configurable: true,
+        });
+
+        const result = generateArchesURL("example_url", null, { id: "123" });
+        expect(result).toBe("/admin/de/example/123");
+    });
+
+    it("should throw an error if the URL name is not found", () => {
+        expect(() =>
+            generateArchesURL("invalid_url", "fr", { id: "123" }),
+        ).toThrowError("Key 'invalid_url' not found in JSON object");
+    });
+
+    it("should replace URL parameters correctly", () => {
+        const result = generateArchesURL("another_url", null, { id: "456" });
+        expect(result).toBe("/admin/another/456");
+    });
+
+    it("should handle missing language code and parameter placeholders", () => {
+        const result = generateArchesURL("another_url", "es", { id: "789" });
+
+        console.log(result);
+        expect(result).toBe("/admin/another/789");
+    });
+});
diff --git a/arches/app/src/arches/utils/generate-arches-url.ts b/arches/app/src/arches/utils/generate-arches-url.ts
@@ -19,7 +19,7 @@ export default function (
         url = url.replace("{language_code}", languageCode);
     }
 
-    Object.entries(urlParams).forEach((key, value) => {
+    Object.entries(urlParams).forEach(([key, value]) => {
         url = url.replace(new RegExp(`{${key}}`, "g"), value);
     });