Scheme Label Editor & Reference Datatype Widget #169
Conversation
arches_lingo/src/arches_lingo/components/generic/LabelEditor.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/generic/LabelEditor.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/generic/LabelEditor.vue
Outdated
Show resolved
Hide resolved
| onMounted(async () => { | ||
| const [languageOpts, typeOpts, statusOpts, metatypeOpts, eventTypeOpts] = | ||
| await Promise.all([ |
There was a problem hiding this comment.
this is fine and I'm not blocking on it, but it still may hammer db depending on what the endpoint is doing. Happy to punt though
There was a problem hiding this comment.
Yeah, let's measure this before we prematurely optimize -- we can always switch to the endpoint that returns all lists and then filter on the frontend.
There was a problem hiding this comment.
Switching to that endpoint may be helpful in avoiding hard-coded list id's because there is graph/node info... I just started working with this endpoint because I was wary of passing around the entire CLM
arches_lingo/src/arches_lingo/components/generic/reference-datatype/ReferenceDatatypeEditor.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/generic/reference-datatype/ReferenceDatatypeEditor.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/generic/reference-datatype/ReferenceDatatypeEditor.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/generic/reference-datatype/ReferenceDatatypeEditor.vue
Outdated
Show resolved
Hide resolved
| @@ -28,3 +28,10 @@ export const ENGLISH = { | |||
| name: "English", | |||
| scope: "system", | |||
| }; | |||
|
|
|||
| export const LANGUAGE_CONTROLLED_LIST = "55ce793b-a51a-4b25-811d-d08ea797f8c3"; | |||
There was a problem hiding this comment.
IMO hardcoding URIs on the frontend isn't a preferred pattern. Is there a way to get these supplied by the backend? If not or if it becomes super complex then okay, but IMO this pattern should be avoided if possible.
aarongundel
force-pushed
the
adg/146-scheme-names
branch
2 times, most recently
from
3f68847 to
fa5dc08
Compare
johnatawnclementawn
force-pushed
the
jmc/147_scheme_label_editor
branch
from
10b4718 to
7e3d631
Compare
Resolves #147