Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app to run as a project #1576

Merged
merged 24 commits into from
Aug 3, 2024
Merged

Conversation

chiatt
Copy link
Member

@chiatt chiatt commented Jul 18, 2024

Updates arches for science to run both as an Arches App and independent project. Includes project updates to support latest changes in Arches dev/7.6.x and moves tests under project's test directory

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
arches_for_science/test_settings.py Show resolved Hide resolved
tests/functions/multicard_resource_descriptor.py Outdated Show resolved Hide resolved
Comment on lines 47 to 50
def setup_databases(self, **kwargs):
ret = super().setup_databases(**kwargs)

app_settings() # adds languages to system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remember to apply the fix from archesproject/arches#11205

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll manually reconcile this (it doesn't get updated by updateproject)

arches_for_science/settings.py Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Co-authored-by: Jacob Walls <[email protected]>
@jacobtylerwalls
Copy link
Member

The line ending check was added because it bit Brett during development. But we probably don't need to care about ontology files. Easy enough to fix here, but do you think this will be enough of a pain point for the community that we should exempt .xml files?

@chiatt
Copy link
Member Author

chiatt commented Aug 2, 2024

The line ending check was added because it bit Brett during development. But we probably don't need to care about ontology files. Easy enough to fix here, but do you think this will be enough of a pain point for the community that we should exempt .xml files?

Ah - I was wondering why that was there. It's hard to say how much trouble it might be for people, but I'd be in favor of the exemption just in case.

@chiatt chiatt merged commit be2a00b into 76-upgrade Aug 3, 2024
5 of 6 checks passed
@chiatt chiatt deleted the make_afs_a_project_and_updateproject branch August 3, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants