Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sample deletion #1405 #1406

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix sample deletion #1405 #1406

merged 1 commit into from
Oct 31, 2023

Conversation

jacobtylerwalls
Copy link
Member

Before, deleting a sample that is selected (e.g. because it had just been saved) would take effect on the tile but not clear itself from the canvas.

Testing instructions

  • deletion of samples/analyses takes effect on the canvas immediately
  • saving, manipulating still works, no shapes get respawned onto the canvas out of nowhere

Closes #1405

chiatt
chiatt approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chiatt chiatt merged commit 186cb21 into dev/1.1.x Oct 31, 2023
1 check passed
@chiatt chiatt deleted the 1405-sample-deletion-fix branch October 31, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiatt chiatt chiatt approved these changes

@chrabyrd chrabyrd Awaiting requested review from chrabyrd

Assignees

@chrabyrd chrabyrd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobtylerwalls @chiatt @chrabyrd