Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable save and cancel buttons in sample/analysis workflows #1347 #1353

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Disable save and cancel buttons in sample/analysis workflows #1347 #1353

merged 1 commit into from
Oct 13, 2023

Conversation

jacobtylerwalls
Copy link
Member

Before, the save & cancel buttons were styled as disabled but not disabled in fact.

Fixes #1347

@jacobtylerwalls jacobtylerwalls requested a review from njkim October 13, 2023 15:58
@jacobtylerwalls jacobtylerwalls linked an issue Oct 13, 2023 that may be closed by this pull request
Analysis area: save and cancel buttons styled as disabled aren't disabled #1347
Closed
njkim
njkim approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@njkim njkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good and works as expected.

@njkim njkim merged commit 0da1d9c into dev/1.1.x Oct 13, 2023
1 check passed
@jacobtylerwalls jacobtylerwalls deleted the 1347-disabled-buttons branch October 13, 2023 18:33
@jacobtylerwalls jacobtylerwalls mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njkim njkim njkim approved these changes

Assignees

@njkim njkim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analysis area: save and cancel buttons styled as disabled aren't disabled
2 participants
@jacobtylerwalls @njkim