Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the logic to save text (prj name), #1332 #1340

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix the logic to save text (prj name), #1332 #1340

merged 1 commit into from
Oct 13, 2023

Conversation

njkim
Copy link
Contributor

@njkim njkim commented Oct 9, 2023

Fix the issue of showing [object Object] when the user undo the edit to initial (empty string), #1332

@njkim njkim requested a review from chiatt October 9, 2023 23:43
@njkim njkim linked an issue Oct 9, 2023 that may be closed by this pull request
Undoing a change to Project Name filed shows [Object object] #1332
Closed
chiatt
chiatt approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chiatt chiatt merged commit a935901 into dev/1.1.x Oct 13, 2023
1 check passed
@jacobtylerwalls jacobtylerwalls deleted the 1332_new_project_name branch October 18, 2023 22:43
This was referenced Oct 18, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiatt chiatt chiatt approved these changes

Assignees

@chiatt chiatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undoing a change to Project Name filed shows [Object object]
2 participants
@njkim @chiatt