Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chemical analysis image workflow #1213

Closed
wants to merge 17 commits into from
Closed

Add chemical analysis image workflow #1213

wants to merge 17 commits into from

Conversation

chiatt
Copy link
Member

@chiatt chiatt commented Jul 6, 2023

Adds workflow for adding derivative images of chemical analyses,

@chiatt chiatt assigned chiatt and ryan86 and unassigned chiatt and ryan86 Jul 19, 2023
chiatt
chiatt commented Jul 19, 2023
View reviewed changes
Copy link
Member Author

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ryan - I added some inline comments just to tidy the code up a bit. There is some code that needs to be moved into the transaction block in add_chemical_analysis_images_file_upload.py

afs/templates/javascript.htm Outdated Show resolved Hide resolved
...s/workflows/add-chemical-analysis-images-workflow/add-chemical-analysis-images-image-step.js Outdated Show resolved Hide resolved
...s/workflows/add-chemical-analysis-images-workflow/add-chemical-analysis-images-image-step.js Outdated Show resolved Hide resolved
...s/workflows/add-chemical-analysis-images-workflow/add-chemical-analysis-images-image-step.js Outdated Show resolved Hide resolved
afs/media/js/views/components/workflows/select-observation-step.js Outdated Show resolved Hide resolved
afs/views/workflows/add_chemical_analysis_images/add_chemical_analysis_images_file_upload.py Outdated Show resolved Hide resolved
afs/views/workflows/add_chemical_analysis_images/add_chemical_analysis_images_file_upload.py Outdated Show resolved Hide resolved
afs/views/workflows/add_chemical_analysis_images/add_chemical_analysis_images_file_upload.py Outdated Show resolved Hide resolved
afs/views/workflows/add_chemical_analysis_images/add_chemical_analysis_images_file_upload.py Outdated Show resolved Hide resolved
afs/views/workflows/add_chemical_analysis_images/add_chemical_analysis_images_file_upload.py Outdated Show resolved Hide resolved
@ryan86 ryan86 force-pushed the 1134_add_chemical_analysis_image_workflow branch from 19637ba to 009ebba Compare July 27, 2023 18:02
@chiatt chiatt linked an issue Sep 22, 2023 that may be closed by this pull request
Stub out Add Chemical Analysis Images workflow #1134
Closed
@chiatt chiatt requested a review from chrabyrd October 26, 2023 22:40
@chiatt chiatt assigned chrabyrd and unassigned chiatt Oct 26, 2023
@chrabyrd chrabyrd changed the base branch from dev/1.0.x to dev/1.1.x October 27, 2023 19:59
@chrabyrd
Copy link
Contributor

chrabyrd commented Nov 1, 2023

closing in favor of #1413

@chrabyrd chrabyrd closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrabyrd chrabyrd Awaiting requested review from chrabyrd

Assignees

@chiatt chiatt

@chrabyrd chrabyrd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stub out Add Chemical Analysis Images workflow
3 participants
@chiatt @chrabyrd @ryan86