Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User gets no error when trying to save a sample without a required node #1419

Closed
chiatt opened this issue Nov 3, 2023 · 1 comment · Fixed by #1427
Closed

User gets no error when trying to save a sample without a required node #1419

chiatt opened this issue Nov 3, 2023 · 1 comment · Fixed by #1427
Assignees
@jacobtylerwalls
Labels
bug Something isn't working

Comments

@chiatt
Copy link
Member

chiatt commented Nov 3, 2023

When saving a sample, a user must provide a name, otherwise the save will fail. When it does, the user should get an alert notifying them that they need to provide a sample name.

image
@chiatt chiatt added the bug Something isn't working label Nov 3, 2023
@chiatt chiatt moved this to 🔖 Ready in afs-pipeline Nov 3, 2023
@jacobtylerwalls jacobtylerwalls moved this from 🔖 Ready to 🏗 In progress in afs-pipeline Nov 6, 2023
jacobtylerwalls added a commit that referenced this issue Nov 6, 2023
@jacobtylerwalls
Fix client-side validation of sample/analysis names #1419
1ff7173
@jacobtylerwalls jacobtylerwalls mentioned this issue Nov 6, 2023
Merged
@jacobtylerwalls jacobtylerwalls linked a pull request Nov 6, 2023 that will close this issue
Fix sample/analysis name validation #1427
Merged
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In progress to 👀 In review in afs-pipeline Nov 6, 2023
@jacobtylerwalls jacobtylerwalls mentioned this issue Nov 7, 2023
Closed
@jacobtylerwalls
Copy link
Member

Fixed in #1427

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in afs-pipeline Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
bug Something isn't working
Projects
afs-pipeline
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sample/analysis name validation archesproject/arches-for-science
2 participants
@chiatt @jacobtylerwalls