Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical thing search results do not indicate if in collection #1356

Closed
chiatt opened this issue Oct 13, 2023 · 1 comment · Fixed by #1357
Closed

Physical thing search results do not indicate if in collection #1356

chiatt opened this issue Oct 13, 2023 · 1 comment · Fixed by #1357
Assignees
Labels
bug Something isn't working

Comments

@chiatt
Copy link
Member

chiatt commented Oct 13, 2023

In the 'Add Objects to Your Project' step of the 'Update Project Collection Workflow' if a user selects a physical thing to add to a collection, it gets listed on the right. However, there is no indication in the list on the left that it has been added. That means that somebody could remove an object from a project by accident if they did not see that it was already added on the right.

If an object has already been added to the collection there should be a clear indication that it has already been added, or it should hidden entirely from the search results so that it can only be removed from the collection by clicking the remove button in the list on the right.
image

@chiatt chiatt moved this to 🔖 Ready in afs-pipeline Oct 13, 2023
@jacobtylerwalls
Copy link
Member

Hmm, I thought I remembered fixing this recently. I'll take a look.

@jacobtylerwalls jacobtylerwalls moved this from 🔖 Ready to 🏗 In progress in afs-pipeline Oct 13, 2023
@jacobtylerwalls jacobtylerwalls self-assigned this Oct 13, 2023
jacobtylerwalls added a commit that referenced this issue Oct 13, 2023
@jacobtylerwalls jacobtylerwalls linked a pull request Oct 13, 2023 that will close this issue
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In progress to 👀 In review in afs-pipeline Oct 13, 2023
@jacobtylerwalls jacobtylerwalls added the bug Something isn't working label Oct 13, 2023
chiatt pushed a commit that referenced this issue Oct 13, 2023
@chiatt chiatt closed this as completed Oct 13, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in afs-pipeline Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants