Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting an ascii file reader config does not remove config from XY Loader UI #1352

Closed
chiatt opened this issue Oct 13, 2023 · 0 comments · Fixed by #1358
Closed

Deleting an ascii file reader config does not remove config from XY Loader UI #1352

chiatt opened this issue Oct 13, 2023 · 0 comments · Fixed by #1358
Assignees
@njkim

Comments

@chiatt
Copy link
Member

chiatt commented Oct 13, 2023 •
edited
Loading

If a user deletes a reader config from the UI, the config persists even though it was successfully deleted on the backend. Refreshing the page reveals the deletion was successful
@chiatt chiatt converted this from a draft issue Oct 13, 2023
@chiatt chiatt changed the title Deleting an ascii file reader config does not remove config from UI Deleting an ascii file reader config does not remove config from XY Loader UI Oct 13, 2023
@chiatt chiatt moved this to 🔖 Ready in afs-pipeline Oct 13, 2023
@njkim njkim self-assigned this Oct 16, 2023
njkim added a commit that referenced this issue Oct 16, 2023
@njkim
Hanlde no custom renderer, #1352
7235544
@njkim njkim mentioned this issue Oct 16, 2023
Merged
@njkim njkim linked a pull request Oct 17, 2023 that will close this issue
Handle when there is no custom renderer, #1352 #1358
Merged
@njkim njkim moved this from 🔖 Ready to 👀 In review in afs-pipeline Oct 17, 2023
chiatt added a commit that referenced this issue Oct 24, 2023
@njkim @chiatt
Handle when there is no custom renderer, #1352 (#1358)
b5fa941 
* Hanlde no custom renderer, #1352

* nit

---------

Co-authored-by: Cyrus Hiatt <[email protected]>
@chiatt chiatt closed this as completed Oct 24, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in afs-pipeline Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njkim njkim

Labels
None yet
Projects
afs-pipeline
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle when there is no custom renderer, #1352 archesproject/arches-for-science
2 participants
@chiatt @njkim