Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update project collection workflow shows child physical things inconsistently #1305

Closed
jacobtylerwalls opened this issue Sep 15, 2023 · 2 comments
Closed

Update project collection workflow shows child physical things inconsistently #1305

jacobtylerwalls opened this issue Sep 15, 2023 · 2 comments
Assignees
@jacobtylerwalls

Comments

@jacobtylerwalls
Copy link
Member

I'm not certain of the exact intended behavior, but something looks inconsistent in this workflow.

  1. Add a phys thing to a project
  2. Take a bunch of samples
  3. Update project collection: compare number of physical things to physical things in sidebar, make changes, save, reopen
update-project-collection.mov
@chiatt
Copy link
Member

chiatt commented Sep 18, 2023

I don't think users should be allowed to save any samples to their project.

@chiatt chiatt moved this to 🔖 Ready in afs-pipeline Sep 18, 2023
@jacobtylerwalls jacobtylerwalls moved this from 🔖 Ready to 🏗 In progress in afs-pipeline Sep 19, 2023
jacobtylerwalls added a commit that referenced this issue Sep 19, 2023
@jacobtylerwalls
Remove sample & sample areas from add things step UI #1305
fe703e8 
They will not appear in select2 widget search suggestion,
in result from search API, or in sidebar initial results.

They will still appear in the final report's
"Child Physical Things" section
jacobtylerwalls added a commit that referenced this issue Sep 19, 2023
@jacobtylerwalls
Remove sample & sample areas from add things step UI #1305
2bd5e56 
They will not appear in select2 widget search suggestion,
in result from search API, or in sidebar initial results.

They will still appear in the final report's
"Child Physical Things" section
@jacobtylerwalls jacobtylerwalls mentioned this issue Sep 19, 2023
Merged
@jacobtylerwalls jacobtylerwalls linked a pull request Sep 19, 2023 that will close this issue
Keep filtering samples by manifest on server response #1304 #1316
Merged
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In progress to 👀 In review in afs-pipeline Sep 19, 2023
jacobtylerwalls added a commit that referenced this issue Sep 19, 2023
@jacobtylerwalls
nit re #1305
da1077f
jacobtylerwalls added a commit that referenced this issue Oct 11, 2023
@jacobtylerwalls
Remove sample & sample areas from add things step UI #1305
18b3538 
They will not appear in select2 widget search suggestion,
in result from search API, or in sidebar initial results.

They will still appear in the final report's
"Child Physical Things" section
@jacobtylerwalls jacobtylerwalls mentioned this issue Oct 11, 2023
Merged
@jacobtylerwalls jacobtylerwalls linked a pull request Oct 11, 2023 that will close this issue
Allow toggling samples & regions in add things step UI #1378 #1343
Merged
@jacobtylerwalls jacobtylerwalls removed a link to a pull request Oct 11, 2023
Keep filtering samples by manifest on server response #1304 #1316
Merged
@jacobtylerwalls jacobtylerwalls moved this from 👀 In review to 🏗 In progress in afs-pipeline Oct 17, 2023
@jacobtylerwalls
Copy link
Member Author

jacobtylerwalls commented Oct 18, 2023 •
edited
Loading

Sounds like we'll wait for more clarity on whether to continue showing samples in a project in this UI.

I looked at my original video, and I think the "57 Physical Things" is intentional; it looks like it's the number of unpaginated search results, at least until you interact with the search, at which point it becomes the number of items in the current search result page. So there might not be a bug to fix here after all.

@jacobtylerwalls jacobtylerwalls moved this from 🏗 In progress to 📋 On hold in afs-pipeline Oct 18, 2023
@jacobtylerwalls jacobtylerwalls moved this from 📋 On hold to Needs Discussion in afs-pipeline Oct 18, 2023
@chiatt chiatt closed this as completed Oct 20, 2023
@github-project-automation github-project-automation bot moved this from Needs Discussion to ✅ Done in afs-pipeline Oct 20, 2023
jacobtylerwalls added a commit that referenced this issue Oct 25, 2023
@jacobtylerwalls
Remove sample & sample areas from add things step UI #1305
3387585 
They will not appear in select2 widget search suggestion,
in result from search API, or in sidebar initial results.

They will still appear in the final report's
"Child Physical Things" section
jacobtylerwalls added a commit that referenced this issue Oct 25, 2023
@jacobtylerwalls
Add toggles re #1305
99eec1f
@jacobtylerwalls jacobtylerwalls removed a link to a pull request Oct 25, 2023
Allow toggling samples & regions in add things step UI #1378 #1343
Merged
jacobtylerwalls added a commit that referenced this issue Oct 26, 2023
@jacobtylerwalls
Add toggles re #1305
9236909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
None yet
Projects
afs-pipeline
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chiatt @jacobtylerwalls