This repository has been archived by the owner on Dec 30, 2024. It is now read-only.
use zerolog.LevelWriter interface for performance #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we log something (e.g. as local log level got set to debug) but we only want to send events for Error to sentry, each event is parsed to check for the log level.
As there is the LevelWriter interface as zerolog suggests for multiple outputs here. That way we might skip parsing the event if the log level is disabled.
This PR implements this.
For reference I implemented benchmarks as well. This are the results on my device