Fixes a panic when Trace level log fired #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a minor issue introduced in 3f53baa The issue is minor, because Trace should not be enabled in most prod deployments, but still bit nasty :)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 52.31% 52.75% +0.43%
==========================================
Files 1 1
Lines 216 218 +2
==========================================
+ Hits 113 115 +2
Misses 96 96
Partials 7 7 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 10, 2024
Merged
|
Ok, thanks, lets fix the panic first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a minor issue introduced in 3f53baa when Write is called with Trace level as Trace is not in the mapping.
Prior it would never get to trying to map trace as it was assumably never enabled.
The issue is minor, because Trace should not be enabled in most prod deployments, but still bit nasty :)
This assumes, that we do not want Trace to be added as Breadcrumb even if breadcrumbs are enabled, if that's incorrect assumption, we should add Trace to level mappings (probably mapped to Debug?)