Skip to content

Commit

Permalink
ci: Pin macos to macos-13 for now
Browse files Browse the repository at this point in the history
macos-latest now runs on Apple Silicon, which fails one test
and probably still needs extra work for the packaging to work.
Until that's figured out, run on macos-13.
  • Loading branch information
arch1t3cht committed May 20, 2024
1 parent 246dbd7 commit 723f181
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@ jobs:
-Dvapoursynth=enabled
- {
name: macOS Debug,
os: macos-latest,
os: macos-13,
buildtype: debugoptimized,
args: -Ddefault_library=static -Dbuild_osx_bundle=true -Dlocal_boost=true --force-fallback-for=ffms2
}
- {
name: macOS Release,
os: macos-latest,
os: macos-13,
buildtype: release,
args: -Ddefault_library=static -Dbuild_osx_bundle=true -Dlocal_boost=true --force-fallback-for=ffms2
}
Expand Down Expand Up @@ -114,7 +114,7 @@ jobs:
popd
- name: Install dependencies (MacOS)
if: matrix.config.os == 'macos-latest'
if: startsWith(matrix.config.os, 'macos-')
run: |
export HOMEBREW_NO_INSTALL_CLEANUP=1
export HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK=1
Expand Down

2 comments on commit 723f181

@0tkl
Copy link

@0tkl 0tkl commented on 723f181 May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to change 'macos-latest' in the "Generate macOS installer" and "Upload artifacts - macOS dmg" step. (Yeah I found my fork failed on macos-13 in the installer generating step and come to figure out why yours passed CI)

@arch1t3cht
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks, fixed.

Please sign in to comment.