Skip to content

Commit

Permalink
switch from wait plugin to utilities plugin for wait step (#59)
Browse files Browse the repository at this point in the history
  • Loading branch information
dustinblack authored Dec 3, 2024
1 parent 868ad50 commit 313823d
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 12 deletions.
9 changes: 5 additions & 4 deletions internal/cliwrapper/cliwrapper_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@ package cliwrapper_test
import (
"errors"
"fmt"
"os"
"os/exec"
"testing"

"go.arcalot.io/assert"
"go.arcalot.io/exex"
"go.arcalot.io/log/v2"
"go.flow.arcalot.io/pythondeployer/internal/cliwrapper"
"os"
"os/exec"
"testing"
)

type TestModule struct {
Expand Down Expand Up @@ -64,7 +65,7 @@ func Test_PullModule_NonexistentGitLocation(t *testing.T) {
// when the location provided included a typo.
func Test_PullModule_ErrorModuleNameFmt(t *testing.T) {
testModule := TestModule{
Location: "git+https://github.com/arcalot/arcaflow-plugin-wait.git@afdc2323805ffe2b37271f3a852a4ce7ac7379e1",
Location: "git+https://github.com/arcalot/arcaflow-plugin-utilities.git@0.6.1",
}

tempdir := "/tmp/pullmodule2"
Expand Down
17 changes: 9 additions & 8 deletions internal/connector/connector_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ import (
"context"
"encoding/json"
"fmt"
"io"
"math/rand"
"os"
"os/exec"
"sync"
"testing"

"go.arcalot.io/assert"
"go.arcalot.io/exex"
"go.arcalot.io/log/v2"
Expand All @@ -13,12 +20,6 @@ import (
pythondeployer "go.flow.arcalot.io/pythondeployer"
"go.flow.arcalot.io/pythondeployer/internal/config"
"go.flow.arcalot.io/pythondeployer/internal/connector"
"io"
"math/rand"
"os"
"os/exec"
"sync"
"testing"
)

func GetPythonPath() (string, error) {
Expand Down Expand Up @@ -119,9 +120,9 @@ func TestDeployConcurrent_ConnectorsAndPluginsWithDifferentModules(t *testing.T)
// the 'latest' branch of cliwrapper.GetModulePath()
"wait": {
stepID: "wait",
location: "arcaflow-plugin-wait@git+https://github.com/arcalot/arcaflow-plugin-wait.git",
location: "arcaflow-plugin-utilities@git+https://github.com/arcalot/arcaflow-plugin-utilities.git",
input: map[string]any{
"seconds": "0.5",
"wait_time_ms": "500",
},
},
}
Expand Down

0 comments on commit 313823d

Please sign in to comment.