Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upload routes fix for multiple upload #1422

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

upload routes fix for multiple upload #1422

wants to merge 4 commits into from
+28 −2

Conversation

fadingNA
Copy link
Contributor

@fadingNA fadingNA commented Nov 8, 2024 •
edited
Loading

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fix error on the client-side when send file the formData the server-side throwing code 500 when upload multiple files

  • Why was this change needed? (You can also link to an open issue here)
    to be able upload multiple file

  • Other information:

  • 🐛 Bug Report: Error uploading multiple files #1420

@vercel Vercel
Copy link

vercel bot commented Nov 8, 2024

@fadingNA is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@fadingNA
Copy link
Contributor Author

fadingNA commented Nov 8, 2024

This maybe work around method, so this approach edit algorithm when uploading multiple file, sending them one by one reduce overhead.

@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 33.96%. Comparing base (bd636d5) to head (91e7c16).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
application/api/user/routes.py 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1422      +/-   ##
==========================================
- Coverage   34.02%   33.96%   -0.06%     
==========================================
  Files          69       69              
  Lines        3403     3409       +6     
==========================================
  Hits         1158     1158              
- Misses       2245     2251       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added application Application and removed frontend labels Nov 10, 2024
@fadingNA fadingNA changed the title change logically to upload file one by one instead of send all in one upload routes fix for multiple upload Nov 10, 2024
dartpain
dartpain approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@dartpain dartpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@dartpain
Copy link
Contributor

Sorry, just noticed conflict, please resolve it.
Thank you!

@fadingNA
Copy link
Contributor Author

Sorry, just noticed conflict, please resolve it. Thank you!

Just resolve to update api/source from this branch aligned with new update.

@vercel Vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 10:22pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dartpain dartpain dartpain approved these changes

Assignees
No one assigned
Labels
application Application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fadingNA @dartpain