Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sorting in documents, minor UI changes #1408

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

ManishMadan2882
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    • added querying on /combine route to sort according to the given fields(date & tokens)
    • default sorting is on data in descending order
    • fix - Nav sidebar pops over active upload modal
    • fix - text overflows from Sources in the Sources sidebar
  • Why was this change needed? (You can also link to an open issue here)
    • adds functionaity in cadet sort icon

Copy link

vercel bot commented Nov 4, 2024

@ManishMadan2882 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.03%. Comparing base (0b7be94) to head (0425190).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
application/api/user/routes.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1408      +/-   ##
==========================================
- Coverage   34.05%   34.03%   -0.03%     
==========================================
  Files          69       69              
  Lines        3374     3376       +2     
==========================================
  Hits         1149     1149              
- Misses       2225     2227       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dartpain dartpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dartpain dartpain merged commit 89529f4 into arc53:main Nov 5, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants