-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix milvus issues #1407
fix milvus issues #1407
Conversation
Signed-off-by: ChengZi <[email protected]>
@zc277584121 is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
Hi @dartpain , could you (or anyone) please take a review |
Good pr, thank you. |
Signed-off-by: ChengZi <[email protected]>
@dartpain thank you, I have removed it , please review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1407 +/- ##
==========================================
- Coverage 34.03% 34.02% -0.02%
==========================================
Files 69 69
Lines 3376 3377 +1
==========================================
Hits 1149 1149
- Misses 2227 2228 +1 ☔ View full report in Codecov by Sentry. |
@holopin-bot @zc277584121 Thank you! |
Congratulations @zc277584121, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm38qnnu584810cl80j27mh8i This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Hey @zc277584121 please fill in this form if you are interested in a t-shirt |
thank you |
Bug fix for milvus.
Comma missing
argument
filter
is not in the_docsearch.similarity_search()
, instead , we can useexpr
add dependency inrequirements.txt