Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix milvus issues #1407

Merged
merged 3 commits into from
Nov 6, 2024
Merged

fix milvus issues #1407

merged 3 commits into from
Nov 6, 2024

Conversation

zc277584121
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix for milvus.
  1. Comma missing
    image

  2. argument filter is not in the _docsearch.similarity_search(), instead , we can use expr

  3. add dependency inrequirements.txt

Signed-off-by: ChengZi <[email protected]>
Copy link

vercel bot commented Nov 4, 2024

@zc277584121 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@zc277584121
Copy link
Contributor Author

Hi @dartpain , could you (or anyone) please take a review

@dartpain
Copy link
Contributor

dartpain commented Nov 5, 2024

Good pr, thank you.
Can we remove milvius as a dependency please from requirements.txt, as we want to keep it lazy loaded.

@zc277584121
Copy link
Contributor Author

@dartpain thank you, I have removed it , please review again

Copy link
Contributor

@dartpain dartpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dartpain dartpain merged commit 7fed92d into arc53:main Nov 6, 2024
4 of 5 checks passed
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.02%. Comparing base (0425190) to head (7fd8e57).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
application/vectorstore/milvus.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1407      +/-   ##
==========================================
- Coverage   34.03%   34.02%   -0.02%     
==========================================
  Files          69       69              
  Lines        3376     3377       +1     
==========================================
  Hits         1149     1149              
- Misses       2227     2228       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dartpain
Copy link
Contributor

dartpain commented Nov 8, 2024

@holopin-bot @zc277584121 Thank you!

Copy link

holopin-bot bot commented Nov 8, 2024

Congratulations @zc277584121, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm38qnnu584810cl80j27mh8i

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@dartpain
Copy link
Contributor

Hey @zc277584121 please fill in this form if you are interested in a t-shirt
https://airtable.com/appikMaJwdHhC1SDP/pagoblCJ9W29wf6Hf/form

@zc277584121
Copy link
Contributor Author

Hey @zc277584121 please fill in this form if you are interested in a t-shirt请填写此表单,如果您对购买 T 恤感兴趣 https://airtable.com/appikMaJwdHhC1SDP/pagoblCJ9W29wf6Hf/form

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application Application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants