Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1219 Too big top margin of message box separator #1385

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

AkashJana18
Copy link
Contributor

Before :
image

After:
image

  • Why was this change needed? (You can also link to an open issue here)
    Better UI/UX
  • Other information:
    Feel free to ask if anymore changes required

Copy link

vercel bot commented Oct 26, 2024

@AkashJana18 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.03%. Comparing base (05f7569) to head (fe16743).
Report is 150 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1385      +/-   ##
==========================================
+ Coverage   33.45%   34.03%   +0.57%     
==========================================
  Files          64       69       +5     
  Lines        3273     3376     +103     
==========================================
+ Hits         1095     1149      +54     
- Misses       2178     2227      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AkashJana18
Copy link
Contributor Author

Hey @ManishMadan2882 @tenokami can you please take a look?

@tenokami
Copy link
Collaborator

@AkashJana18 Great change! Thank you

@AkashJana18
Copy link
Contributor Author

Hey @tenokami can you merge it as well, as today all the fest are ending. I would be glad if it merged before the fest ends.

@ManishMadan2882
Copy link
Collaborator

Hi @AkashJana18
please check the overflow in input text
image
Also the height of input box has changed.
Thanks

@AkashJana18
Copy link
Contributor Author

AkashJana18 commented Nov 2, 2024

Fixed the issue

image
image

Copy link

vercel bot commented Nov 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 9:56pm

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AkashJana18
The scrollbar is removed from the input box, please check it once with larger inputs.
image
Thanks!

@AkashJana18
Copy link
Contributor Author

I have made the requested change @ManishMadan2882 can you please review it?

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AkashJana18 !

@dartpain dartpain merged commit edc81d8 into arc53:main Nov 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Too big top margin of message box separator
4 participants