Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature update: Enhanced viewport handling and scrollbar styling. #1378

Closed
wants to merge 7 commits into from

Conversation

PentesterPriyanshu
Copy link

@PentesterPriyanshu PentesterPriyanshu commented Oct 25, 2024

Added Firefox-compatible scrollbar styling By default, Firefox uses its own scrollbar styling, which can look inconsistent compared to other browsers

Added fallback for vh where dvh is unsupported.
Improved dark mode scrollbar contrast.
Ensured Firefox compatibility with custom scrollbars.
Other information:

Enhances cross-browser support and dark mode UX. Non-breaking.

Added Firefox-compatible scrollbar styling  By default, Firefox uses its own scrollbar styling, which can look inconsistent compared to other browsers
Copy link

vercel bot commented Oct 25, 2024

@PentesterPriyanshu is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@PentesterPriyanshu
Copy link
Author

PentesterPriyanshu commented Oct 25, 2024

@ManishMadan2882

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PentesterPriyanshu
The design of the scrollbars in light and dark mode look different
image
Screenshot from 2024-10-26 02-47-56

updated changes as requested
@PentesterPriyanshu
Copy link
Author

PentesterPriyanshu commented Oct 26, 2024

@ManishMadan2882 Screenshot from 2024-10-26 05-28-39
Screenshot from 2024-10-26 05-28-18
now both looks same

@PentesterPriyanshu
Copy link
Author

@dartpain

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PentesterPriyanshu There is no change in Firefox

it is the best i can achieve since firefox has limited features ,while webkit browsers  have different
@PentesterPriyanshu
Copy link
Author

This is the best consistency we can achieve, as Firefox has fewer features than WebKit-based browsers. @ManishMadan2882, please merge this pull request, or suggest any improvements if needed. I’ve made significant improvements to the scrollbar and maintained consistency. I noticed that even ChatGPT shows similar differences, likely due to Firefox's limited feature set.

@ManishMadan2882
Copy link
Collaborator

Agree with you, Firefox has fewer customisation for scrollbar.
There is an error in the index.css in your previous commit
image

To be honest, I don't think these changes will be required as there is no update in the scrollbar.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants