Drafting release of v0.10.0 #2380
Conversation
| @@ -121,7 +121,7 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| fetch-depth: 0 | |||
| submodules: "recursive" | |||
| submodules: recursive | |||
There was a problem hiding this comment.
why removed ""? a sign for merging child branches?
There was a problem hiding this comment.
So, all of the checkouts are recursive, i.e. they will descend into submodules (recursively!) and fetch those in addition. However, in all other instances we don't use ", so I removed them here, too.
CHANGELOG.md
Outdated
| * Documentation overhaul | ||
| * Performance improvements | ||
| - Label resolution uses hashes instead of strings | ||
| - Spike delivery is now up to 30% faster leading |
There was a problem hiding this comment.
this sentence reads odd to me
| @@ -1,3 +1,34 @@ | |||
| # v0.10.0 (*08.08.2024*) | |||
|
|
|||
| ## Major Changes since v0.9.0 | |||
CHANGELOG.md
Outdated
| ## Major Changes since v0.9.0 | ||
| * Automatic network generation from high-level specifications. | ||
| * Units at the user interface including scaling and conversion. | ||
| * Morphologies are now loaded through a unified interface, bundling morphology, meta data, and segment tree. |
There was a problem hiding this comment.
this sentence reads odd to me
There was a problem hiding this comment.
also, maybe use 'metadata' to be consistent?
CHANGELOG.md
Outdated
| - Better support for source builds on MacOS (aarch64) | ||
| - `modcc` no longer allows internal variables (`v`, `celsius`, ...) as `ASSIGNED` | ||
| - Better support for raw (C++) mechanisms | ||
| * MC cells are now cable cells |
There was a problem hiding this comment.
Stands (stood?) for Multi-Compartment as in mc_cell_group. However, all text and interface calls them cable. Thus we removed this inconsistency by renaming the code. It's purely cosmetic.
cmake/GitSubmodule.cmake
Outdated
There was a problem hiding this comment.
cmake is not my thing so I cannot review it in a responsible way.
There was a problem hiding this comment.
This will check if .git is present and fail if it isn't. However, scikit-build-core copied over everything except .git so this check failed. I added an inner check to warn users when they run into this general scenarion.
pyproject.toml
Outdated
There was a problem hiding this comment.
a small step in Arbor and also a small step in computational neuroscience! but still. congratulations!
Draft PR for new release.